Adar Dembo has posted comments on this change.

Change subject: [java client] Tight-ish loop in master lookups if a tablet 
doesn't have a leader
......................................................................


Patch Set 1:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/4570/1//COMMIT_MSG
Commit Message:

PS1, Line 9: possiblity
Nit: possibility


PS1, Line 19: 101
While we're at it, can we remove this upper bound? It's a completely arbitrary 
number and it doesn't make sense; only the deadline expiring should make us 
stop retrying.


http://gerrit.cloudera.org:8080/#/c/4570/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

PS1, Line 1409: send
Nit: throw


Line 1498:     // TODO: Handle the situation when multiple in-flight RPCs are 
queued waiting
I know you just moved this comment, but I didn't really understand it 
originally either. What makes this situation special such that we need 
additional logic for it? What happens today when multiple RPCs are waiting to 
find out who the leader master is?


PS1, Line 1499: determine
Nit: determined


http://gerrit.cloudera.org:8080/#/c/4570/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java:

PS1, Line 50: "testDisconnect"
This means that if testDisconnect() fails and is retried by maven, it'll fail 
again because the testDisconnect table will already exist.

Until such a time that we clean up the mini cluster state after each test like 
the C++ tests, we need to retain the idiom of appending the time to the table 
name.


Line 157:     KuduTable table = createTable("testNoLeader", basicSchema, 
options);
Same here.


-- 
To view, visit http://gerrit.cloudera.org:8080/4570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2bd53b03551642e4d036d322e1e592b7c2cfec
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to