Adar Dembo has posted comments on this change. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4570/1//COMMIT_MSG Commit Message: PS1, Line 19: 101 > It's useful for cases exactly like this one. If you hit "attempt=101" then It's useful for development, yes, but not useful (and I would argue potentially harmful) in production. Instead, perhaps we can noisily log when we exceed 100 attempts? Or make the 100 attempt limit test-only? http://gerrit.cloudera.org:8080/#/c/4570/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 1498: // TODO: Handle the situation when multiple in-flight RPCs are queued waiting > They all try to find who the leader is. If you have 1000 RPCs, they will al Hmm, maybe we should acquire a "master lookup permit" here then? Not relevant to the current patch in any case. But, since you're moving the comment, can you reword it to make it clear why this is a TODO? That is, we should implement the optimization you just told me about. -- To view, visit http://gerrit.cloudera.org:8080/4570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2bd53b03551642e4d036d322e1e592b7c2cfec Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
