Adar Dembo has posted comments on this change. Change subject: [java client] Temporarily ignore row count regressions in ITClient ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4597/1/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: Line 389: LOG.warn("Row count regressed: " + rowCount + " < " + lastRowCount); > Like I'm saying in the commit message, looping until we get a correct count I agree with David, and I don't see why looping would be messy. Can't we just store a local copy of lastRowCount and loop countRowsInScan() until the row count exceeds lastRowCount, or until some deadline elapses (if we want to be paranoid about deadlocks)? -- To view, visit http://gerrit.cloudera.org:8080/4597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e79a6c7aaf069294a6ca40e487947d14d9f2aa7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
