Adar Dembo has posted comments on this change. Change subject: KUDU-1669. Java ITClient test can orphan processes ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4598/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: I really don't like how ITClient uses thread interruption to clean up, and this workaround just makes the affected code even messier. Instead, can you modify ITClient to use cooperative thread signaling for clean up? It should be straight-forward; it's how we clean up every single test thread in the C++ tests. Line 237: PROCESS_INPUT_PRINTERS.add(thread); Let's defer this until after the try/catch below. Then we won't need a corresponding remove() to clean up in the event of an error. -- To view, visit http://gerrit.cloudera.org:8080/4598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0085323ba9ea544488c6ce896d8627f24ea69f4b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
