Alexey Serbin has posted comments on this change. Change subject: [client-test] added basic test for RWYW behavior ......................................................................
Patch Set 1: > |The test loops when it sees timeout from a tablet replica > catching-up, not just to get expected number or rows. > > You're right, but it also does loop for RYW meaning it's not > actually testing RYW. Fwiw I like the documentation value of the > test (i.e. it's documenting the _hack_ we need to currently do to > _likely_ get RYW) just not sure what it's currently testing. Maybe > we could add this to the docs or something? Sure, that's an options as well. Since you know best on this matter, I think we should do whatever you think is the better option. OK, let me then update this changeset just to add some comments in the in-line documentation for both C++ and Java clients. -- To view, visit http://gerrit.cloudera.org:8080/4583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c237a41a1434199848ac5fc978fab27e565e2d8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
