Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4630
to look at the new patch set (#2).
Change subject: Running kudu-spark tests alone fail finding build dir
......................................................................
Running kudu-spark tests alone fail finding build dir
When running kudu-spark tests alone using 'mvn test', you end up with a
failure as follows:
03:03:30.930 [WARN - main] (TestUtils.java:108) Unable to find build dir!
myUrl=file:/Users/mladen/.m2/repository/org/apache/kudu/kudu-client/1.1.0-SNAPSHOT/kudu-client-1.1.0-SNAPSHOT-tests.jar
Essentially, the kudu-client jar is typically installed by maven, and
placed in your local machine's .m2 repository. The build dir lookup
logic in TestUtils assumes that the TestUtils class is in your kudu
source code git repo. However, it won't be when it has been installed
by maven.
The fix here is to have kudu-spark find the location of its own scala
test files, and set the system property appropriately that will end up
overriding the lookup logic done in the kudu-client package. Hence, it
should find the binaries for kudu-master, etc without a problem.
These changes also modify TestUtils.java slightly, to publicly make
available helper functions and constants so that we're not duplicating
code. This also makes it easier to adopt this strategy in other test
cases.
Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
2 files changed, 46 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/4630/2
--
To view, visit http://gerrit.cloudera.org:8080/4630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib452086cf57a3cb4249bb7c1f91c7572e55466ce
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <[email protected]>
