Adar Dembo has posted comments on this change. Change subject: kernel_stack_watchdog: avoid blocking threads starting ......................................................................
Patch Set 2: Code-Review+2 (2 comments) Looks good, though it looks like you still have a broken test. Between this patch and the other one you submitted to speed up thread creation in TSAN: what techniques did you use to find these root causes? http://gerrit.cloudera.org:8080/#/c/4626/2//COMMIT_MSG Commit Message: PS2, Line 12: TSAN defers signal-handling Just so I understand, what you mean is that TSAN handles the signal but takes its time before forwarding it to the process? DumpThreadStack() waits up to a second, so I presume you're still seeing stack traces but delayed in the high hundreds of ms or something like that? PS2, Line 21: However, it's still important to prevent these : threads from _exiting_ while we are looking at their TLS But presumably delaying Thread.Join() has little to no effect on test flakiness the way delaying Thread.Create() may? -- To view, visit http://gerrit.cloudera.org:8080/4626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7af85ade6ec9050843ec5b146d26c2549c503d8f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
