Todd Lipcon has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4476/2/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: Line 565: // TODO(todd) count of number of ops failed due to consensus queue overflow. > Yeah, I think I was one of the ones to vote to keep them, only realized tid I could change the bot to only comment on changed lines (rather than changed lines + context) but I think it often makes sense to look for issues within a few lines of the change, since for example changing a method body might make one of the arguments unused or whatever. How about a mass automated change that will make all of the current TODO: into TODO(author) where author is determined by git-blame? -- To view, visit http://gerrit.cloudera.org:8080/4476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81614d26328b0fbba37bf279f59717e05a07b816 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
