Alexey Serbin has posted comments on this change. Change subject: [flaky tests] Increase the timeout in ClientTest.TestFailedDnsResolution ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4643/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS2, Line 1937: string nit: 'static const string' or at least 'const string' to express this variable is a reference and isn't changing at all. PS2, Line 1938: == Should it be '!=' instead? PS2, Line 1939: ASSERT_TRUE nit: consider using ASSERT_LE() instead of ASSERT_TRUE() PS2, Line 1939: dns nit: DNS -- To view, visit http://gerrit.cloudera.org:8080/4643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fa3ceb7215d60cd23efabf729731254524e1625 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
