Todd Lipcon has posted comments on this change.

Change subject: WIP: KUDU-1365. Add leader pre-elections
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4694/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

Line 1908:     StartElection(NORMAL_ELECTION, reason);
> is there an interleaving in which we're already started a real election (bu
Yea, that looks possible, but I don't think it causes problems except for a 
potential extra election in a relatively rare case. If the pre-election for N+1 
completes before we heard from N, then it'll bump its term to N+1 and call the 
real election for N+1. Then if N completes successfully, it'll just ignore the 
result coming from the prior term in DoElectionCallback.

Any suggestion for how we should handle this case differently? I think we 
already had a similar kind of case where it was possible to start an election 
for term N, not hear back, and then start one for N+1 under load, but given we 
do the backoff thing, eventually we should be spacing them out enough to 
succeed.


-- 
To view, visit http://gerrit.cloudera.org:8080/4694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcfabd8c9ffe31f17ab768542a046426f656db43
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to