Todd Lipcon has posted comments on this change.

Change subject: WIP: KUDU-1365. Add leader pre-elections
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4694/2/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

Line 1908:     StartElection(NORMAL_ELECTION, reason);
> Just afraid that this interleaving will not be so unlikely with pre-electio
There's not a guaranteed serialization point, but there is some kind of 
"softer" thing that helps make this less likely: the peers that are voting will 
be holding some lock while writing their "real election" vote to disk, and that 
would make the pre-election respond with "too busy". So, the pre-election that 
happens while a real election was in progress is quite likely to get denied due 
to hitting this code path.

+1 on trying this out with various stress tests and address it if we see this 
being a problem. Thanks for calling it out, though, I hadn't considered it.


-- 
To view, visit http://gerrit.cloudera.org:8080/4694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcfabd8c9ffe31f17ab768542a046426f656db43
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to