Dan Burkert has posted comments on this change.

Change subject: KUDU-1682. Lock contention on table locations cache in Java 
client
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4706/1/java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
File 
java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java:

Line 58:       rwl.readLock().lock();
> I don't suppose synchronized(rwl.readLock()) would work? The try/finally is
It will compile, but it has different (wrong) semantics.


-- 
To view, visit http://gerrit.cloudera.org:8080/4706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f6ba8f4fced6f043f7132fd11078044b004ea21
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to