Adar Dembo has posted comments on this change.

Change subject: [java client] Extract RemoteTablet from AsyncKuduClient
......................................................................


Patch Set 1:

(4 comments)

As with the other patch, has anything actually changed (besides method 
visibility) in the moved code?

http://gerrit.cloudera.org:8080/#/c/4719/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

PS1, Line 589: tablet == null
I presume that in the transition from clientFor() to 
tablet.getLeaderConnection() you only added null checks like this one when they 
were explicitly needed.

So, under what circumstances is tablet == null here?


PS1, Line 689: getConnectionToLeader()
This method doesn't exist.


Line 1304:       rt.init(tabletPb);
Can we do this as part of createTabletFromPb()? In fact, maybe 
createTabletFromPb() should be a static RemoteTablet method (and we'd hide its 
constructor)? Or do it as part of the constructor?


http://gerrit.cloudera.org:8080/#/c/4719/1/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java:

Line 74:   private final ConnectionCache connectionCache;
Based on our discussion, sounds like this will go away because RemoteTablet 
will no longer be creating TabletClients.


-- 
To view, visit http://gerrit.cloudera.org:8080/4719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d06a573e4307c76a7aebab05cd5238fb0d9a2c6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to