Adar Dembo has posted comments on this change. Change subject: [java client] Extract ip2client out of AsyncKuduClient ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4717/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java: Line 91: this.kuduClient = client; > Java is more advanced than you think ;) I see. Nevertheless, circular references introduce unnecessary tight coupling and make it difficult to understand the underlying code. I understand that this may not be something we can address immediately, but we should work to address it. I haven't looked at TabletClient much but we should factor out whatever AsyncKuduClient logic it uses into a separate class, then have both AsyncKuduClient and TabletClient (via ConnectionCache) depend on that class. Line 279: static String getIP(final String host) { > It's used in both classes, so I'd rather keep the connection-related stuff Ah, didn't realize it was also being called from inside this class. -- To view, visit http://gerrit.cloudera.org:8080/4717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48b0f3f262abd5ee26869202f661b3c25158f39c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
