Will Berkeley has posted comments on this change. Change subject: KUDU-1680 - [python] Improve PartialRow Usability ......................................................................
Patch Set 1: (13 comments) Pretty much just some nits. http://gerrit.cloudera.org:8080/#/c/4760/1/python/kudu/client.pxd File python/kudu/client.pxd: PS1, Line 42: add_to_session Nit: slight preference for calling this apply, in line with C++ and Java. http://gerrit.cloudera.org:8080/#/c/4760/1/python/kudu/client.pyx File python/kudu/client.pyx: PS1, Line 653: , sswapped space and comma " ," -> ", " PS1, Line 653: ParitalRow spelling PS1, Line 653: d. is used to initialize/create/setup the insert? PS1, Line 655: names or indexes They can be a mix of name and index too, right? And both name and index could be specified? That's weird but I guess it's Python. PS1, Line 670: rita see above PS1, Line 670: ,a see above PS1, Line 670: d. see above PS1, Line 687: d ,a ParitalRow with values from an input record. same 3 comments as insert, upsert PS1, Line 704: d ,a ParitalRow with values from an input record. ditto PS1, Line 2043: arital sp http://gerrit.cloudera.org:8080/#/c/4760/1/python/kudu/schema.pyx File python/kudu/schema.pyx: PS1, Line 546: ,a ParitalRow with values from an input record. same comments as elsewhere- swapped space and comma, misspelled PartialRow, missing end of sentence. http://gerrit.cloudera.org:8080/#/c/4760/1/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: PS1, Line 173: {'key': 2, : 'int_val': 222, : 'string_val': 'upserted'} Could you add an op that uses indexes too? Just as a sanity check. -- To view, visit http://gerrit.cloudera.org:8080/4760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c9f57358e5048528398818fc80f32b27531a423 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
