Alexey Serbin has posted comments on this change. Change subject: Free SASL connection objects when negotiation completes ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4761/1/src/kudu/rpc/sasl_client.cc File src/kudu/rpc/sasl_client.cc: PS1, Line 175: After negotiation, we no longer need the SASL library object > I considered that, but didn't want to have to pass it around everywhere.. i If you think it makes more sense to have it as a member, that's fine. Could you at least add a comment about ephemeral nature of this member in the .h file? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7aada1e44a80af94c5c069e9f583aedcd78a68b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
