Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Decouple TabletClient from RemoteTablet ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/4757/1/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java: PS1, Line 49: } > {@link TabletClient}s are currently... Done Line 95: void connectTS(Master.TSInfoPB tsInfoPB) throws UnknownHostException { > private or @VisibleForTesting (here and elsewhere) This is used by AsyncKuduClient. PS1, Line 99: {uuid} > This doesn't work correctly, the braces have to be empty. Done Line 167: readLock.lock(); > call getClient here instead of dealing with locks. Done Line 187: ArrayList<Deferred<Void>> deferreds = new ArrayList<>(); > I think it's still an improvement to move the ArrayList creation inside the Ok I'll just move everything in then. http://gerrit.cloudera.org:8080/#/c/4757/1/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: Line 70: synchronized (tabletServers) { > I think it's fine in the ctor. There's some kind of happens before relatio Done http://gerrit.cloudera.org:8080/#/c/4757/1/java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/TabletClient.java: Line 623: * This method is not synchronized. You need to synchronize on this > Should this be updated? Oh right, thanks! http://gerrit.cloudera.org:8080/#/c/4757/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestUtils.java: Line 298: static Common.PartitionPB.Builder getFakePartitionPB() { > This is a valid partition. Not sure if that matters or not. I won't say bogus then, but it is fake as it's not represented on a cluster. -- To view, visit http://gerrit.cloudera.org:8080/4757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3ad2190c7e2c7f51cb9ffe6ed3348b62488e675 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
