Jordan Birdsell has posted comments on this change. Change subject: KUDU-1684 - [python] Add Scan Resource Metrics Capabilities ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4675/2/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: PS2, Line 233: ds, row_in > this part of the test doesn't seem that relevant anymore Done http://gerrit.cloudera.org:8080/#/c/4675/2/python/kudu/tests/test_scantoken.py File python/kudu/tests/test_scantoken.py: Line 216: def verify_pred_type_scans(self, preds, row_indexes, count_only=False): > this test seems pretty redundant with the other scanner test -- isn't it a Agreed, done. -- To view, visit http://gerrit.cloudera.org:8080/4675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c4057bd2644e46bdbf8bae0d4a768306e2dbd9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jordan Birdsell <jordantbirds...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
