Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1691 - [python] Replaced group varint encoding with 
bitshuffle
......................................................................


Patch Set 1:

(1 comment)

Thanks for the patch Greg! Can you also add dictionary encoding?  Make sure to 
also include a test for this, take a look at test_schema.py:test_encoding.

http://gerrit.cloudera.org:8080/#/c/4796/1//COMMIT_MSG
Commit Message:

PS1, Line 9: is an internally used encoding which was removed for the C++ api.
I would say its no longer supported and as such being removed from the Python 
API.


-- 
To view, visit http://gerrit.cloudera.org:8080/4796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I198fb6c43c1fbfd236f07b100934b8d9036bf16e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Jordan Birdsell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to