Adar Dembo has posted comments on this change. Change subject: block_manager: cosmetic changes to the LBM ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4847/2/src/kudu/util/pb_util.h File src/kudu/util/pb_util.h: PS2, Line 309: filename > nit: if it's a path, not just filename, may be it's better to name this met I went with filename() to be consistent with filename() from RWFile, WritableFile, etc. -- To view, visit http://gerrit.cloudera.org:8080/4847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5990ac1946cb2aab331a9b618ba4710ccfdf3e3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
