David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4837/2/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: Line 180: throw new RuntimeException("Unknown replica selection mechanism " + replicaSelection); > Can throw an unchecked exception yeah. I think adar was referring to whether you should throw an exception for the default: case, but I think your answer to my question answers that question too. -- To view, visit http://gerrit.cloudera.org:8080/4837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bb08c9c78271a0065c8aa8fb9b0f3301f84e828 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
