Will Berkeley has posted comments on this change. Change subject: WIP: enable GSSAPI for servers ......................................................................
Patch Set 4: Code-Review+1 (3 comments) Just trying to follow along with security stuff a bit...feel free to disregard comments http://gerrit.cloudera.org:8080/#/c/4765/4/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: PS4, Line 632: do we need to canonicalize/lookup the FQDN here I think so if we want to check for a valid keytab on start-up (see below). PS4, Line 646: valid : // keytab when we start up I think so. A little research suggests it's normal (in Hadoop) to fail at startup if the keytab is invalid. PS4, Line 652: simplify and get rid of the AuthStore interface +1 I don't see a good reason to support un/pw auth -- To view, visit http://gerrit.cloudera.org:8080/4765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I595469e9cc8b2b2f57e9726014eeeb8112595801 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
