Jean-Daniel Cryans has posted comments on this change.

Change subject: [java client] Remove timeouts when joining in the sync client
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4871/1//COMMIT_MSG
Commit Message:

Line 22: client then it might join forever. The latter means we expose bugs, so 
it's not that bad.
> could we do something like add 10 seconds to the timeout and join with that
I was inclined to use an even bigger number TBH, but the problem is that we 
have to use that number every time we join which I thought was kinda messy.


-- 
To view, visit http://gerrit.cloudera.org:8080/4871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff4c0783e3c338d268ee1e37b000d45517b3880b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to