Jordan Birdsell has posted comments on this change. Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4795/2//COMMIT_MSG Commit Message: PS2, Line 10: capabilit > nit: sp Done http://gerrit.cloudera.org:8080/#/c/4795/2/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: PS2, Line 136: {'key': 10} > I'm wondering what happens if one sets invalid column names or wrongly type The PartialRow usability patch just abstracted the old op[key] = value approach. That being said, that API had no tests :). I've added a test case to account for this. Thanks for calling this out, I found an uncaught exception that was causing SIGSEGVs. -- To view, visit http://gerrit.cloudera.org:8080/4795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
