Will Berkeley has posted comments on this change. Change subject: [kudu-spark] Allow build against Spark 2.0 and Scala 2.11 ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4886/1//COMMIT_MSG Commit Message: PS1, Line 15: maintain separate modules compatible with 1.6 and 2.0. > So why not do this right? You think Spark 1.x doesn't have much longer to l I don't know how much longer Spark 1.x will be in common use. The issue is more that the change is so minor it's easy to keep one module. Happy to split it up though if you think that's best. The split will definitely happen if/when we want features that only 2.x provides. I guess that's also an argument for it: we can develop 2.x-dependent features without more hassle with a separate module. It's also an argument against since there's two possibly diverging modules to try and maintain feature parity between. -- To view, visit http://gerrit.cloudera.org:8080/4886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie055ac1e8f7be7cb992124afa0b601376db14f91 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Chris George <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
