Will Berkeley has posted comments on this change.

Change subject: [kudu-spark] Allow build against Spark 2.0 with Scala 2.11
......................................................................


Patch Set 11:

> It looks like the Scala 2.11 build has new warnings that we should
 > maybe fix in another patch, a bunch of
 > 
 > 05:06:19 [WARNING] 
 > /home/jenkins-slave/workspace/kudu-0/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala:31:
 > warning: no valid targets for annotation on value batchSize - it is
 > discarded unused. You may specify targets with meta-annotations,
 > e.g. @(transient @param)
 > 05:06:19 [WARNING]               @transient batchSize: Integer,
 > 
 > and a bunch of
 > 
 > 05:06:27 [WARNING] 
 > /home/jenkins-slave/workspace/kudu-0/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala:339:
 > warning: This catches all Throwables. If this is really intended,
 > use `case _ : Throwable` to clear this warning.
 > 05:06:27 [WARNING]       case _ => fail()

Most definitely. I've already started looking at them.

-- 
To view, visit http://gerrit.cloudera.org:8080/4886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie055ac1e8f7be7cb992124afa0b601376db14f91
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Chris George <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: No

Reply via email to