Adar Dembo has posted comments on this change. Change subject: [fs_manager] Disallow write operations on read_only fs handles ......................................................................
Patch Set 1: > One follow-up question though: Even if we provide fs_manager_.DeleteXYZ() > routines, how can we prevent the caller from directly doing > fs_manager->env()->deleteFile() ? perhaps we could keep the Env as > private inside FsManager and provide public access to env() > routines from FsManager ? Like FsManager::DeleteFile, > FsManager::CreateDir() etc. We can't. It's too easy to obtain an Env from anywhere (see Env::Default()), so this is probably the best we can do. But, it's still better than what we've got today. -- To view, visit http://gerrit.cloudera.org:8080/4891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8425ce3e739d0d37869edc879fc16dc48c89eb7e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
