Dan Burkert has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/4781/5//COMMIT_MSG Commit Message: PS5, Line 23: callStatus=Network error: [Peer 3926a6a73e994152be1336beb434154e] Connection reset on [id: 0xc83743df] why is this status duplicated from the previous element? http://gerrit.cloudera.org:8080/#/c/4781/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: PS5, Line 691: new RpcTraceObject.RpcTraceObjectBuilder( : request.method(), : RpcTraceObject.Action.QUERY_MASTER) : .build()); This formatting is pretty weird. Maybe chop down the RpcTraceObjectBuilder args? http://gerrit.cloudera.org:8080/#/c/4781/5/java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceObject.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceObject.java: Line 78: return "RpcTraceObject{" + Use the guava ToStringHelper -- To view, visit http://gerrit.cloudera.org:8080/4781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69ef56acc071b9f80b34e38c1821df4096f54907 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
