Alexey Serbin has posted comments on this change. Change subject: [security] added TlsServer and TlsClient wrappers ......................................................................
Patch Set 2: > These are just useful for tests, right? Maybe we should move them > into a security/test/ directory or something? (haven't looked at > patch yet) Yes, exactly -- those are just for tests. I'm planning to add some additional tests for the certificate management stuff using these TlsClient and TlsServer wrappers. I think moving them into the tests subdirectory is a very good idea. Will do. BTW, on the same note (but may be in a separate changelist): what do you think about doing the same with the mini_kdc stuff? -- To view, visit http://gerrit.cloudera.org:8080/4926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80b5e636e0dbe028b9e8262ced0a4a1607ffd239 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
