Adar Dembo has posted comments on this change.

Change subject: [OpenSSL] require at least 1.0.1 version
......................................................................


Patch Set 1:

(1 comment)

But el6.4 ships with 1.0.0, which I think we intend to build against (since 
it's the last release without symbol versions). What do we need from 1.0.1?

http://gerrit.cloudera.org:8080/#/c/4937/1/CMakeLists.txt
File CMakeLists.txt:

Line 833: find_package(OpenSSL 1.0.1 REQUIRED)
Nit: not your fault but would you mind adding a little "## OpenSSL" header just 
above this line?


-- 
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1b60f730f3d6e5645a310fb40df39d04367e688
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to