Mike Percy has posted comments on this change. Change subject: block_manager: various changes to disk space reservation checking ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4831/4/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: Line 933: ASSERT_EQ(1, bm_->available_containers_by_data_dir_.begin()->second.size()); > The existing comment describes it though: we're asserting that we've got a ok http://gerrit.cloudera.org:8080/#/c/4831/4/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: Line 55: DEFINE_int64(fs_data_dirs_reserved_bytes, 0, > Hmm, how have my changes broken backwards compatibility for fs_data_dirs_re oh, you only changed the name of log_block_manager_full_disk_cache_seconds ... that is less of a big deal. Line 67: METRIC_DEFINE_gauge_uint64(server, data_dirs_full, > I thought about adding that, but the number doesn't change at runtime (it's It just means that you have to hard-code this information in your metrics calculation, you can't just infer it remotely. In any case, we could add it later. -- To view, visit http://gerrit.cloudera.org:8080/4831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica2bb710a246ef09890554d1d6ff6da528145a6e Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
