Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 2 ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4950/1//COMMIT_MSG Commit Message: PS1, Line 10: We thus rely on having the exceptions' messages to have : the RPC's string representation in them in order to have the traces make their : way back to the user. > Nit: a little clunky ("have" or "having" three times), reword? Done PS1, Line 15: be embedding the KuduRpc or just the list of traces. > Nit: "by embedding the KuduRpc or just its list of traces" Done Line 23: [101ms] querying master, [101ms] Sub rpc: GetTableLocations sending RPC to server e6e499debd804a8183b85d20a33ad560 > Why were these two entries ("querying master" and "Sub rpc: ...") on the sa Because I didn't break up the lines correctly. http://gerrit.cloudera.org:8080/#/c/4950/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceObject.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcTraceObject.java: Line 104: case SEND_TO_SERVER: > You can encapsulate these in AppendToStringBuilder(RpcTraceObject, StringBu I'll call it appendToStringBuilder if you don't mind. -- To view, visit http://gerrit.cloudera.org:8080/4950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c37143a587971f0e8985c59f4ab1d0c164c3723 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
