Adar Dembo has posted comments on this change. Change subject: cmake: search for all required Kerberos binaries ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4954/1/cmake_modules/FindKerberos.cmake File cmake_modules/FindKerberos.cmake: PS1, Line 36: find_package_handle_standard_args(${binary} REQUIRED_VARS "${binary}_BIN" : FAIL_MESSAGE "Kerberos ${binary} not found: security tests will fail") This means we may see a series of "Kerberos ... not found" messages, right? How about maintaining a list of binaries that weren't found, then emitting just one message with it? -- To view, visit http://gerrit.cloudera.org:8080/4954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic680409088f487ee9fa28cbd7e8f2a95a034b4b2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
