Alexey Serbin has posted comments on this change. Change subject: ssl: switch to older APIs for initializing SSL ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4957/1/src/kudu/util/net/ssl_factory.cc File src/kudu/util/net/ssl_factory.cc: PS1, Line 84: ctx_ == nullptr nit: I didn't notice that earlier, but while you are at it -- since ctx_ is a smart pointer, it's more idiomatic to write something like if (!ctx_) { ... } instead of if (ctx_ == nullptr) PS1, Line 90: on early versions of RHEL6 Does it make sense to specify that it's 6.4 and earlier? -- To view, visit http://gerrit.cloudera.org:8080/4957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08fd5c3f6f8d2c228f760604dcecd7f1439578fb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
