Dinesh Bhat has posted comments on this change. Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown ......................................................................
Patch Set 2: (2 comments) TFTR Mike. http://gerrit.cloudera.org:8080/#/c/4958/1/src/kudu/rpc/acceptor_pool.cc File src/kudu/rpc/acceptor_pool.cc: Line 103: // Calling shutdown on an accepting (non-connected) socket is illegal on most > Update comment Done http://gerrit.cloudera.org:8080/#/c/4958/1/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: Line 95: // the first pool has been shutdown. > nit: s/ShutDown/Shutdown/ for consistency w/ rest of the code base, here an Done -- To view, visit http://gerrit.cloudera.org:8080/4958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ed12bd5e4be5ee932196e77ce2f0ecd3810c992 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
