Adar Dembo has posted comments on this change. Change subject: macOS: fix compile error introduced by 141de3377e6bdd ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5009/1/src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc File src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc: Line 187: int64_t ExternalMiniClusterFsInspector::GetTabletSuperBlockMTimeOrDie( Hmm. Not your fault obviously, but I have some requests for other (small) changes here: 1) Could you drop the std:: prefix from std::string on L188? 2) Could you add a static MonoTime::FromTimeSpec() method that mirrors MonoTime::ToTimeSpec(), change this method to use it, and return a MonoTime here instead? -- To view, visit http://gerrit.cloudera.org:8080/5009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2a9556810feeb3128b97d60afb18a2547e0af5c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
