Dinesh Bhat has posted comments on this change. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() ......................................................................
Patch Set 3: > Dinesh: Yeah I saw that and I pondered what you are suggesting. > Ended up not doing it because in the HybridClock::NowForMetrics is > really just used for metrics and does actually update the clocks's > logical value if needed. For a clock with a physical component this > makes sense: we want it to read the latest time. However for a > logical clock just getting the current time shouldn't change it. > > It bummed me a little bit to break the symmetry, but since these > are not virtual methods I resigned to living with it :) Sounds good, thank you for explaining, I was lazy enough to not to look into the definition of HybridClock::Now() earlier. -- To view, visit http://gerrit.cloudera.org:8080/4989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac6f8dd9e79657b81409127e539e509da4b2b8de Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
