Adar Dembo has posted comments on this change. Change subject: Check sanity of standard file descriptors when starting daemons ......................................................................
Patch Set 1: Code-Review+2 (1 comment) Ah, I was hoping this could be tested with a death test. Not possible? http://gerrit.cloudera.org:8080/#/c/5030/1/src/kudu/util/init.cc File src/kudu/util/init.cc: PS1, Line 60: This is a rare enough issue that people can deal with : // the core dump. If this turns out to happen more commonly, I suggest we reopen the missing fds from /dev/null instead. We'll see how it goes. -- To view, visit http://gerrit.cloudera.org:8080/5030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie57efbb63c588e39ac70777ba7b21496aae7fc27 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
