Alexey Serbin has posted comments on this change. Change subject: [c++client] fixed KUDU-1743 ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5048/3/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: PS3, Line 748: is > Nit: was Done PS3, Line 754: CheckIfFinishedFlush > CheckForFinishedFlush() Done Line 756: // * T2 does the same > Nit: could you terminate all the sentences here with periods? Done http://gerrit.cloudera.org:8080/#/c/5048/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS1, Line 2516: vector<unique_ptr<KuduPartialRow>> splits; : unique_ptr<KuduPartialRow> split(schema_.NewRow()); : ASSERT_OK(split->SetInt32("key", kRowNum > Wouldn't the table names be unique even if they were just Substitute("$0", Ah, yes -- everything is teared down after a test finishes. -- To view, visit http://gerrit.cloudera.org:8080/5048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3054d7f7c00dd937f4307fb01a5a0054b8ae27f7 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
