Hello Adar Dembo, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5064
to review the following change.
Change subject: [c++client] fixed KUDU-1743
......................................................................
[c++client] fixed KUDU-1743
KUDU-1743: GetPendingErrors() not returning all errors after Flush()
A race has been discovered during Impala + Kudu testing: if working
with tables split among multiple tablet servers, a rare race condition
manifests itself as not having all the errorrs in the error collector
upon return from the KuduSession::Flush() method.
This patch fixes the race and adds corresponding test for that.
Change-Id: I3054d7f7c00dd937f4307fb01a5a0054b8ae27f7
Reviewed-on: http://gerrit.cloudera.org:8080/5048
Reviewed-by: Adar Dembo <[email protected]>
Tested-by: Kudu Jenkins
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.h
M src/kudu/client/error_collector.h
M src/kudu/client/session-internal.h
6 files changed, 116 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/5064/1
--
To view, visit http://gerrit.cloudera.org:8080/5064
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3054d7f7c00dd937f4307fb01a5a0054b8ae27f7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.1.x
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins