Adar Dembo has submitted this change and it was merged. Change subject: env: change various file filename() functions to return copies ......................................................................
env: change various file filename() functions to return copies I'm doing this so that the file cache implementation of these calls has the flexibility to return newly constructed strings. I don't expect it to be a big deal because: 1) These are generally only called in LOG() statements. 2) Return value optimization should reduce the number of copies. Change-Id: Iae4a74963b5b12676b54831e2f6adddc4a6583c5 Reviewed-on: http://gerrit.cloudera.org:8080/5085 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert <[email protected]> --- M src/kudu/util/env-test.cc M src/kudu/util/env.h M src/kudu/util/env_posix.cc M src/kudu/util/pb_util.cc M src/kudu/util/pb_util.h 5 files changed, 11 insertions(+), 11 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae4a74963b5b12676b54831e2f6adddc4a6583c5 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
