Jean-Daniel Cryans has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4945/5//COMMIT_MSG Commit Message: Line 7: Reject CREATE TABLE ops with even replication factor > If we have a JIRA filed for this issue/task, it's a good practice to start +1 http://gerrit.cloudera.org:8080/#/c/4945/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 898: return Status::InvalidArgument(Substitute("Reject CREATE TABLE with even replication " Shouldn't this setup error with a MasterErrorPB? -- To view, visit http://gerrit.cloudera.org:8080/4945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
