David Ribeiro Alves has posted comments on this change. Change subject: [hybrid_clock] update on NowWithError's signature ......................................................................
Patch Set 1: what is the goal here? we usually frown on optional args in outside of tests without a good reason, and this adds an extra branch... it also seems a bit silly from a public api prespective to call NowWithError and then not want the error back, there's Now for that. I do see that we ignore it internally but that's more because of internal reuse. -- To view, visit http://gerrit.cloudera.org:8080/5108 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64eb9502c7fc4c10007f4f88f3346394fbdd50e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
