Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1691 - [python] Replaced group varint encoding with 
bitshuffle
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4824/2/python/kudu/tests/test_schema.py
File python/kudu/tests/test_schema.py:

Line 131:             del foo
> I deleted foo to make sure that there is no variable persistence in the for
Yea, theres no way to access the column spec information in the client. I agree 
that the delete is unnecessary, but i dont think its hurting anything being 
there


-- 
To view, visit http://gerrit.cloudera.org:8080/4824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18a611e746d48879d6e9988abcee42e0354dcfdc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: [email protected]
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jordan Birdsell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes

Reply via email to