Alexey Serbin has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 ......................................................................
Patch Set 2: (1 comment) > fuzz-itest used to create snapshots at timestamp 0, which > previously were silently transformed to no "no timestamp" snapshot > scans. This check avoids the silent transformation. > looking back we probably shouldn't have changed the int64's to > uint64's. > On the server the "no timestamp" value is not 0 and we never do a > max(no_timestamp, some_timestamp) like we do on the client. I think the main issue here not about changing types, but having some special values. If it make sense, we could leave 0 as a valid timestamp, but instead add a boolean field in Scan::Configuration to determine a condition when timestamp is not set. http://gerrit.cloudera.org:8080/#/c/5155/2/src/kudu/client/client.cc File src/kudu/client/client.cc: PS2, Line 1092: IllegalState I'm late here, but just to clarify: why IllegalState() but not InvalidArgument()? Also, why not do add this check in Configuration::SetSnapshotRaw() method instead? -- To view, visit http://gerrit.cloudera.org:8080/5155 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc5997f226752d59c56104b26e9b58b8640d0298 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
