Adar Dembo has posted comments on this change. Change subject: KUDU-1448. Enable AVX2 bitshuffle at runtime ......................................................................
Patch Set 1: (3 comments) Just passing through... http://gerrit.cloudera.org:8080/#/c/5166/1/src/kudu/gutil/cpu.cc File src/kudu/gutil/cpu.cc: Line 61: : "a"(info_type) My x86 knowledge is weak, but I'll ask the dumb question anyway: should the same change be applied here? Or maybe we should acknowledge that this is dead code as far as Kudu is concerned and remove it. Line 71: : "a"(info_type), "c"(0) Does Kudu use cpuid to selectively enable/disable other features? Or is this use of avx2 the first such case? http://gerrit.cloudera.org:8080/#/c/5166/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 447: # iochain.c doesn't benefit from the architecture optimization. Does it make sense to include iochain.c in the above if only to simplify the build logic a bit? Or would doing so impact runtime negatively? -- To view, visit http://gerrit.cloudera.org:8080/5166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied8887c0240a649158085676fdd08ab8628bf7d6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
