Dan Burkert has posted comments on this change. Change subject: util: add file cache ......................................................................
Patch Set 3: (6 comments) Still reviewing, but I'm going to move to R3, so putting what I've got on R2. http://gerrit.cloudera.org:8080/#/c/5146/2//COMMIT_MSG Commit Message: PS2, Line 41: hareds shards? http://gerrit.cloudera.org:8080/#/c/5146/2/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: Line 62: RWFile* CacheValueToRWFile(Slice s) { Can you rely on the fact that the colon is at position 3 in order to skip the find call? DCHECK_EQ(cache_key[3], ':'); return cache_key.substr(4); Line 81: Substitute("Could not close file $0", rwf->filename())); remove virtual and change OVERRIDE to override. Line 343: friend class FileCache; operator on preceding line http://gerrit.cloudera.org:8080/#/c/5146/2/src/kudu/util/file_cache.h File src/kudu/util/file_cache.h: Line 80: // document thread safety guarantees of the class where otherwise unspecified. Line 130: template <class FileType> I think we typically call these 'ToStringDebug'. -- To view, visit http://gerrit.cloudera.org:8080/5146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26d02f71b0a9644de0b669875941adae5f426345 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
