Alexey Serbin has posted comments on this change. Change subject: [TestSignalStackTrace] scope cleanup for test thread ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5171/1/src/kudu/util/debug-util-test.cc File src/kudu/util/debug-util-test.cc: Line 87: auto cleanup_thr = MakeScopedCleanup([&]() { t->Join(); }); > Doesn't it also need to do l.CountDown() though? Otherwise t won't exit. Good catch. It seems I missed the essence here :) -- To view, visit http://gerrit.cloudera.org:8080/5171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee425a12fe0101cd9f1ff61d28a8af20a105cbc2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
