Mike Percy has posted comments on this change. Change subject: Add Reinserts to tablet_history_gc-itest ......................................................................
Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/4997/10/src/kudu/integration-tests/tablet_history_gc-itest.cc File src/kudu/integration-tests/tablet_history_gc-itest.cc: Line 396: // TODO: Allow for reinsert onto deleted rows after KUDU-237 has been Remove this comment, also should we consider treating insert and reinsert as basically the same case for this test? It's probably better to have the possibility of batches with a combination of inserts and reinserts anyway. Line 569: int32_t row_key = *std::next(deleted_rows_.begin(), random.Uniform(num_deleted_rows)); hrm, O(k*n) kind of sucks, i wonder if this needs to be made faster -- To view, visit http://gerrit.cloudera.org:8080/4997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b774b14d79bd7c0c0bf62b585bd70d6d975feaa Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
