David Ribeiro Alves has posted comments on this change. Change subject: [scan] test for reusing snapshot timestamp when not set ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5163/2/src/kudu/integration-tests/consistency-itest.cc File src/kudu/integration-tests/consistency-itest.cc: PS2, Line 435: shared_ptr<KuduClient> client; : ASSERT_OK(cluster_->CreateClient(nullptr, &client)); : // Scan the table at a snapshot: let the servers pick the timestamp. : shared_ptr<KuduTable> table; : ASSERT_OK(client->OpenTable(table_name_, &table)); > That would decrease the boilerplate code in this test a bit (one less line ah missed you were using the client below (thought for a sec it was only the scanner). makes sense to leave it then PS2, Line 490: // Insert an additional row into the first tablet. : ASSERT_OK(InsertTestRows(client.get(), table.get(), 1, 1)); > This is to check that the timestamp is taken from the first tablet server: ah, makes sense. sgtm -- To view, visit http://gerrit.cloudera.org:8080/5163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7282976580cc15ef330871a838bbf7e46230ceb6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
